Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modify image config depending on next version #831

Merged
merged 4 commits into from
Aug 22, 2024
Merged

feat: modify image config depending on next version #831

merged 4 commits into from
Aug 22, 2024

Conversation

sambrodie
Copy link
Contributor

Description of the Change

images.remotePatterns requires a minimum Next.js version, 14. Rather than updating the config to always use remotePatterns, this change will detect the Next version from the project's package.json file, and then use remotePatterns if the version is >=14 or domains if the version is <14.

Closes #812

Changelog Entry

Added check for Next version and configuration properties.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@sambrodie sambrodie requested a review from nicholasio July 31, 2024 20:44
@sambrodie sambrodie self-assigned this Jul 31, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: a8a162e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@headstartwp/next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headstarwp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 5:11pm

@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headstartwp

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

📦 Next.js Bundle Analysis for @10up/headstartwp

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headstartwp

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headstartwp

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@nicholasio nicholasio merged commit c1d70ec into develop Aug 22, 2024
13 checks passed
@nicholasio nicholasio deleted the feature/next-image-config branch August 22, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasio nicholasio nicholasio approved these changes

Assignees

@sambrodie sambrodie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

images.domains deprecation
2 participants
@sambrodie @nicholasio